exp: claude release command#795
Conversation
|
CC: @david-martin @maleck13 for thoughts |
📝 WalkthroughWalkthroughAdds a new release procedure document describing a command-driven workflow for creating releases from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d3ad96a to
026f0a6
Compare
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
david-martin
left a comment
There was a problem hiding this comment.
Would this replace RELEASING.md?
026f0a6 to
8bfd46b
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/commands/release.md:
- Around line 39-45: The steps for creating a new release branch conflict with
branch protection: the sequence that directly pushes release-X.Y.Z to upstream
must be changed so it either documents that pushing requires admin override or
instructs to open a PR to create the branch from main; update the block that
references git checkout main, git checkout -b release-X.Y.Z and git push
upstream release-X.Y.Z (and the subsequent git checkout -b release-{VERSION}) to
explicitly state "git push upstream release-X.Y.Z # Requires admin access to
bypass protection" or replace the direct push with instructions to request a
maintainer/create a PR to add the protected release-* branch from main.
- Line 67: The release script uses "git add -u config/ charts/ docs/ bundle/
scripts/" which only stages changes to tracked files and will miss newly created
files; replace that command with "git add -A config/ charts/ docs/ bundle/
scripts/" (or "git add .") to ensure new manifests are included, and optionally
add a verification step like "git status --porcelain" or "git ls-files --others
--exclude-standard" after the add to fail or warn if untracked files remain;
update the line containing the git add -u invocation accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9a6a29a8-5bb6-4a0b-a824-31e8933d0a5f
📒 Files selected for processing (1)
.claude/commands/release.md
Potentially? It was formed from it originally |
Signed-off-by: Jason Madigan <jason@jasonmadigan.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.claude/commands/release.md (2)
107-107:⚠️ Potential issue | 🟡 Minor
git add -uwon't stage new files.If
make bundlecreates new manifests, they won't be staged. Previous review flagged this.Fix
-git add -u config/ charts/ docs/ bundle/ scripts/ +git add config/ charts/ docs/ bundle/ scripts/🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/commands/release.md at line 107, The current release step uses "git add -u config/ charts/ docs/ bundle/ scripts/" which only stages modifications and deletions and will miss any new files produced by make bundle; update the command in .claude/commands/release.md (the line with "git add -u config/ charts/ docs/ bundle/ scripts/") to a form that stages new files as well (for example replace with "git add -A config/ charts/ docs/ bundle/ scripts/" or "git add . --all config/ charts/ docs/ bundle/ scripts/") so newly created manifests are included in the commit.
174-174:⚠️ Potential issue | 🟡 MinorSame
git add -ulimitation here.New files from
make bundlewon't be staged.Fix
-git add -u config/ charts/ docs/ bundle/ scripts/ +git add config/ charts/ docs/ bundle/ scripts/🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/commands/release.md at line 174, Replace the current git staging command "git add -u config/ charts/ docs/ bundle/ scripts/" because "-u" will not stage newly created files; use a command that includes new files such as "git add -A config/ charts/ docs/ bundle/ scripts/" or "git add --all" (or simply "git add ." when appropriate) so that files produced by make bundle are included.
🧹 Nitpick comments (1)
.claude/commands/release.md (1)
116-125: Add language identifier to code blocks.Lines 116, 121, 181, 186: Fenced code blocks should specify
bashfor syntax highlighting.Example fix
> Ready for you to push and open the PR. Run: -> ``` +> ```bash > git push -u origin release-{VERSION} > ```Apply similar change to lines 121, 181, 186.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/commands/release.md around lines 116 - 125, Add the "bash" language identifier to the fenced code blocks that contain shell commands so they render with syntax highlighting: update the triple-backtick fences that wrap the git push and gh pr create commands (the blocks currently showing ``` with contents "git push -u origin release-{VERSION}" and the "gh pr create --repo Kuadrant/mcp-gateway..." block, plus the two other fenced code blocks referenced) to start with ```bash instead of ```, leaving the block contents unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.claude/commands/release.md:
- Line 107: The current release step uses "git add -u config/ charts/ docs/
bundle/ scripts/" which only stages modifications and deletions and will miss
any new files produced by make bundle; update the command in
.claude/commands/release.md (the line with "git add -u config/ charts/ docs/
bundle/ scripts/") to a form that stages new files as well (for example replace
with "git add -A config/ charts/ docs/ bundle/ scripts/" or "git add . --all
config/ charts/ docs/ bundle/ scripts/") so newly created manifests are included
in the commit.
- Line 174: Replace the current git staging command "git add -u config/ charts/
docs/ bundle/ scripts/" because "-u" will not stage newly created files; use a
command that includes new files such as "git add -A config/ charts/ docs/
bundle/ scripts/" or "git add --all" (or simply "git add ." when appropriate) so
that files produced by make bundle are included.
---
Nitpick comments:
In @.claude/commands/release.md:
- Around line 116-125: Add the "bash" language identifier to the fenced code
blocks that contain shell commands so they render with syntax highlighting:
update the triple-backtick fences that wrap the git push and gh pr create
commands (the blocks currently showing ``` with contents "git push -u origin
release-{VERSION}" and the "gh pr create --repo Kuadrant/mcp-gateway..." block,
plus the two other fenced code blocks referenced) to start with ```bash instead
of ```, leaving the block contents unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 06b406e6-b856-48be-b5d8-14802ba31dc1
📒 Files selected for processing (1)
.claude/commands/release.md
Experimental claude command for semi-automated releases.
Used this during 0.6 final
Summary by CodeRabbit